Review main Merged

73099[TASK] Avoid TBE_EDITOR declaration via synchronous script tag

Benjamin Franzke CR +2 V +2 Easy +3 −24 updated 01/21/22, 15:58

Commit message

TBE_EDITOR is only needed for the legacy, inline-javascript based,
TBE_EDITOR.customEvalFunctions registry, therefore the synchronous
script jsfunc.tbe_editor.js is almost always loaded without
ever being used in requests if no legacy code is loaded.

The remaining usages of TBE_EDITOR.registerCustomEvaluation have been
migrated to TBE_EDITOR.registerCustomEvaluation in #95954
(rsee eturnFieldJs in redirects SourceHost evaluation), therefore
TBE_EDITOR.customEvalFunctions is subject for deprecation anyway, and
it's fine to guard any TBE_EDITOR.customEvalFunctions assignment
with a fallback-factory for TBE_EDITOR and to remove jsfunc.tbe_editor.js.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5