Review main Abandoned Breaking

73123[WIP][!!!][TASK] Use symfony API to resolve language

Stefan Froemken CR 0 V 0 Hard +231 −125 updated 01/27/23, 20:12

Commit message

Symfony routing comes with a {_locale} placeholder
to set language identifier as so-called
staticSuffix for URIs.
With this patch we respect the full URI and URIs
like de-de.html are possible now.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 913

  1. Stefan Froemken uploaded patch set 1 01/21/22, 22:15

  2. Stefan Froemken uploaded patch set 2 01/21/22, 23:06

  3. core-ci voted on patch set 1 V -1 01/22/22, 00:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22383

  4. Stefan Bürk commented on patch set 2 01/22/22, 00:20

    Unresolved

    Wrong branch, has been renamed. Must be 'main'. Please revisit your commit message template if used, for further patches.
  5. Stefan Bürk updated the commit message in patch set 3 01/22/22, 00:20

  6. core-ci voted on patch set 2 V -1 01/22/22, 01:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22387

  7. Stefan Bürk commented on patch set 3 01/22/22, 01:23

    I think your aproach won't work out with this direction. I pinged you on slack, maybe we can have a call on some of the next days. That's more to clarify and understand really what you are trying to solve. I guess I have some ideas to get your use case in the end eventually working, but would need quite more work on some edges in dedicted patches - so let's bang our heads togheter on slack and let's discuss what we can do here (together).
  8. core-ci voted on patch set 3 V -1 01/22/22, 02:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22392

  9. Stefan Froemken uploaded patch set 4 01/23/22, 14:45

  10. core-ci voted on patch set 4 V -1 01/23/22, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22435

  11. Stefan Froemken commented on patch set 4 01/23/22, 14:49

    This patch is still not working, but I think the new column for navigationLocale could have future. Further using the priority mechanism sounds promising. Will see.
  12. Oliver Hader commented on patch set 4 11/03/22, 12:04

    How is it used, how is it configured, what do people need to do to make use of this feature? Having some examples and optionally some test cases would be great.
  13. Stefan Froemken abandoned the change 01/27/23, 20:12

    I have talked to Stefan Bürk. This problem is not solved within a day or two and needs a lot of parts to pay attention for.