Review main Merged

73142[BUGFIX] Prevent PHP warning in menu data processors

Oli Bartsch CR +2 V +2 Easy +13 −9 updated 01/24/22, 19:18

Commit message

Check if the decoded menu is iterable,
before passing it to "foreach".

Note: No early return is used, since
this would be a change in behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 01/24/22, 18:02

  2. Oli Bartsch uploaded patch set 2 01/24/22, 18:08

  3. core-ci voted on patch set 1 V -1 01/24/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22480

  4. core-ci voted on patch set 2 V +1 01/24/22, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22481

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/24/22, 18:58

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/24/22, 19:18

  7. Benni Mack merged patch set 3 01/24/22, 19:18