Review main Merged

73145[TASK] Tag importmaps to include configuration for dynamic imports

Benjamin Franzke CR +2 V +2 Normal +138 −27 updated 02/13/22, 10:47

Commit message

Dynamic JavaScript imports require their respective importmap
configurations to be loaded, therefore it is now allowed to tag
import configurations in order to be loaded when a certain
dispatcher is added to the current response.

This patch adds tags for the currently used dynamic imports.
The tags are added via includeTaggedImports and
might be side-loaded via the ResolveJavaScriptImportEvent.

Notes:

* In the pageRenderer->loadRequireJsModule we currently
  transparently load all configurations in backend context, but
  once we switch all these calls to loadJavaScriptModule(),
  we need to be very explicit about all the required
  importmaps. This patch prepares for that.

* The EventDispatcher is an optional dependency for the ImportMap class
  as the events and tags are not required in the InstallTool importmap.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 10