Review main Merged

73161[TASK] Revert "[TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable"

Benjamin Franzke CR +2 V +2 Easy +6 −8 updated 02/14/22, 09:09

Commit message

This reverts commit 425f94f553b14fa63668beaa82489316f0f3ea4a.

Reason for revert:
It would have been better to use getStreamlinedFileName()
directly instead of changing the processJsFile() method.
Also JavaScriptRenderer is reinitialized in reset(),
therefore the initialization needs to be done again there.
Last but not least this fix should also be backported to v11
as JavaScriptHandler changed between v11.5.3 and v11.5.4 and
therefore a cache-bust hash is required as well.
In order to fix this in a clean way, this patch is reverted
and will be replaced by a new one.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2