73182[TASK] Add possibility to manipulate JavaScriptModuleInstruction items
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 56
-
Oliver Hader uploaded patch set 1 01/27/22, 17:22
-
core-ci voted on patch set 1 V +1 01/27/22, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22582
-
Benjamin Franzke commented on patch set 1 01/27/22, 19:33
I understand the usecase for findJavaScriptModuleInstructions, do you already have one for the removal? Reason why I'm asking: We got some more state in JavaScriptRenderer (and ImportMap) since the introduction of ES6 https://review.typo3.org/c/Packages/TYPO3.CMS/+/73004 To a) know which extensions need to be loaded (because there have been javascript module instructions), and a global overview of JavaScriptModuleInstruction flags, in order to know whether requirejs needs to be loaded. We'd ideally sync these when removing an existing module instruction. This works for the flags, but will be harder for the importmap (although it would be quite "ok" to simply let that stay) Still, I'd like to know which usecase you have for removals in mind. -
Oliver Hader commented on patch set 1 01/28/22, 07:51
Reply Unresolved
> I understand the usecase for findJavaScriptModuleInstructions, do you already have one for the removal? No specific yet... and basically those cases might be solvable with the `find...` function already in custom extension code... I'd be fine to set this patch to work-in-progress and on hold for the time being - just removing the `remove...` part also is fine. -
Oliver Hader marked it work in progress 01/28/22, 07:51
-
Oliver Hader abandoned the change 01/24/25, 10:27