Review main Merged

73183[BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction

Oliver Hader CR +2 V +2 Easy +49 −1 updated 01/28/22, 13:12

Commit message

Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding flags were just
given once, that would not have lead to problems. However, enabling
the same bits multiple times would have lead to side-effects
like disabling the added bit or enabling others.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2