Review main Abandoned Breaking

73192[WIP][!!!][TASK] All extensions must have a composer.json file

Benni Mack CR 0 V 0 Easy +4 −0 updated 10/02/22, 10:21

Commit message

This patch only detects extensions (also in non-composer
mode) which have a composer.json manifest file.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 01/28/22, 14:09

  2. core-ci voted on patch set 1 V +1 01/28/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22627

  3. Christian Kuhn commented on patch set 1 01/29/22, 10:50

    PackageManager.php:358 Unresolved

    Enforcing composer.json existance even for non-composer instances in v12 however is a good thing - it is a required pre-work for further composer-only works anyways. I think simply ignoring an extension without a valid composer.json in non-composer mode could add a lot of confusion, though. I'd change the patch to actively throw a non-catchable (global, e.g. \RuntimeException) that includes the extension name in question here - the exception code will then link to docs.typo3.org and could have some more advise on how to create a proper composer.json.
  4. Simon Schaufelberger commented on patch set 1 09/24/22, 23:15

    Unresolved

    can this make it into v12?
  5. Benni Mack abandoned the change 10/02/22, 10:21

    won't do it, no benefit for non-composer installations as long as we evaluate the ext_emconf.php