73195[WIP][FEATURE] Add option to recursive fetch data for config.cache
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1017
-
TYPO3com uploaded patch set 1 01/28/22, 20:44
-
core-ci voted on patch set 1 V -1 01/28/22, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22634
-
Stefan Bürk commented on patch set 1 CR -1 01/29/22, 00:04
Some first comments after a first quick look-through, thus -1 for now. Anyway, not sure about this at all. At least we need tests for this, on the other hand we should check if this option is passed/used somewhere else to clear caches - not sure about this. Have to recheck this. Will pick up this tomorrow.Unresolved
Casing - should be '[FEATURE]'. Not sure about "option", is it really a option ? Maybe just me.TypoScriptFrontendController.php:3201UnresolvedUse an if/else condition to do the filter_var() only once. or at least to it before and save the result in a variable to be used in the conditions. Not getting the filter_var() yet at all .... maybe better checking this with a simple bool-type cast directly after unpacking the exploded array in L3150 and avoid these filter_var() calls here at all. Same fir condition in L3191.TypoScriptFrontendController.php:3204Unresolvedcgl issue - space must be removed (that's the cgl pipeline issue)TypoScriptFrontendController.php:3211UnresolvedWhy changing this back to toe old onion-return type method ? Please leave this 'executeQuery()' to be expressive. -
Christian Kuhn commented on patch set 1 01/29/22, 11:25
Ok, here is the thing: We all know this 'max' page cache lifetime calculation in FE is clumsy. The essential issue is here, that TSFE does not know which records are rendered on a page, and single record rendering does not notify TSFE about lifetime changes. This is a conceptual problem in FE rendering. The FE TS cache.config.pageId.x option is thus basically a hack to mitigate the underlying misconception by giving integrators a chance to obtain 'max' lifetime values from records if they *know* these records are used on a page - the classic example are news records with start/endtime in a sysfolder, used on some pages. We will have to tackle all that at some point, but it will be a bigger and possibly breaking thing, and we don't have a full concept for that right now as far as I know. The two questions we have to ask here: a) Does it actively help integrators if we further extend the given option with another feature? b) Will this feature actively hurt us when we start tackling the underlying issue? a) is obviously 'yes', otherwise we wouldn't see this patch. For b), looking at the code, the current implementation is "mostly harmless" and without many side effects. It shouldn't hurt much to have this. Thus, in general, I see no issue extending the config option with a recursive tree operation. The docs and the code should however state this is potentially expensive (if you're doing it wrong, the could would traverse *a huge tree* triggering tons of queries. Note: This part could be a target for a recursive CTE query, which would make it dramatically more efficient ... we *may* see something like that in v12. I'd thus say: "yeah, let's get it done if it helps people in general" plus "but document the risks, too". -
Thomas Anders commented on patch set 2 01/31/22, 21:39
Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 01/31/22, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22829
-
Thomas Anders commented on patch set 3 01/31/22, 22:12
Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 01/31/22, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22832
-
Thomas Anders uploaded patch set 4 02/09/22, 19:54
-
core-ci voted on patch set 4 V -1 02/09/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23300
-
Thomas Anders uploaded patch set 5 02/09/22, 22:16
-
core-ci voted on patch set 5 V -1 02/09/22, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23306
-
Stefan Bürk uploaded patch set 6 02/15/22, 23:43
-
core-ci voted on patch set 6 V +1 02/15/22, 23:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23695
-
Stefan Bürk commented on patch set 6 CR -1 02/17/22, 14:20
blocked meanwhile. Benni is working on a handfull TSFE pre-patches, will pick up this then. -
Christian Kuhn commented on patch set 6 11/27/24, 18:14
Hey. This patch was in limbo for quite a while now, and meanwhile - with the tsfe works in v13 - lifetime of page cache can be influenced much better, plus there is api to register 'used records' which will influence page lifetime as well. As such, I'd say, this patch is not the way to go anymore since ext authors have better ways to influence cache lifetimes now. I hope its ok to abandon here. -
Christian Kuhn abandoned the change 11/27/24, 18:14