Review main Merged

73202[TASK] Avoid typehint docblocks for FunctionalTestCase properties

Stefan Bürk CR +2 V +2 Hard +3 −621 updated 01/30/22, 00:05

Commit message

This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock type
hint of base class:

* $coreExtensionsToLoad
* $testExtensionsToLoad
* $pathsToLinkInTestInstance
* $pathsToProvideInTestInstance

This resolves a couple of issues from phpstan baseline.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 75

Show 55 more files