Review main Merged

73206[TASK] Improve PHP code examples in a ReST file

TYPO3com CR +2 V +2 Easy +8 −9 updated 02/05/22, 11:35

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 01/29/22, 21:08

  2. core-ci voted on patch set 1 V +1 01/29/22, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22674

  3. Christian Kuhn commented on patch set 1 CR -1 01/29/22, 22:04

    Deprecation-85389-VariousPublicPropertiesInFavorOfContextAPI.rst:48

    this looks fishy. why is there a enumeration now, there is a missing empty lite after header ...?
  4. Christian Kuhn uploaded patch set 2 02/05/22, 09:10

  5. Christian Kuhn updated the commit message in patch set 3 02/05/22, 09:10

  6. Christian Kuhn commented on patch set 3 02/05/22, 09:11

    Deprecation-85389-VariousPublicPropertiesInFavorOfContextAPI.rst:48 Reply

    Done
  7. Christian Kuhn voted on patch set 3 V +1 CR +1 02/05/22, 09:11

  8. core-ci voted on patch set 2 V +1 02/05/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23042

  9. core-ci voted on patch set 3 V +1 02/05/22, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23043

  10. Oliver Klee voted on patch set 3 CR +1 02/05/22, 11:04

  11. Susi Moog voted on patch set 3 V +1 CR +1 02/05/22, 11:35

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 02/05/22, 11:35

  13. Christian Kuhn merged patch set 4 02/05/22, 11:35