Review main Merged

73213[TASK] Avoid state and undefined properties in tests

Christian Kuhn CR +2 V +2 Easy +14 −35 updated 01/30/22, 00:06

Commit message

There is often no point in having test class state
which may lead to undefined class properties and
more complex test setups.

The patch simplifies a test to show this is more
easy to grasp and solve a phpstan error along the way.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2