73218[BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Andreas Kienast uploaded patch set 1 01/30/22, 12:10
-
core-ci voted on patch set 1 V +1 01/30/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22711
-
Stefan Bürk voted on patch set 1 CR +1 01/30/22, 12:43
-
Stefan Bürk wrote 01/30/22, 12:55
Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech> -
Stefan Bürk commented on patch set 1 01/30/22, 12:55
LiveSearch.php:337Using reference here should be avoided, as no writing access needed. Fallback should be added here too.LiveSearch.php:338here too -
Andreas Kienast uploaded patch set 2 01/30/22, 12:57
-
Stefan Bürk commented on patch set 2 V +1 CR +1 01/30/22, 13:09
LiveSearch.php:337ReplyDoneLiveSearch.php:338ReplyDone -
core-ci voted on patch set 2 V +1 01/30/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22713
-
Benni Mack voted on patch set 2 V +1 CR +1 01/30/22, 13:19
-
Andreas Kienast voted on patch set 2 V +2 CR +2 01/31/22, 06:51
-
Andreas Kienast merged patch set 3 01/31/22, 06:51