Review main Merged

73220[TASK] Add PHPStan plugin for psr/container

Benjamin Franzke CR +2 V +2 Normal +64 −20 updated 01/30/22, 16:04

Commit message

The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in core ServiceProviders once we enable phpstan level 5
as invalid parameter usage will then be detected.

The plugin already revealed wrong interface usage in
functional MFA tests which are fixed as a drive by.

Commands executed:

  composer req --dev bnf/phpstan-psr-container:^1.0
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6