Review 11.5 Merged

73224[TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors

Christian Kuhn CR +2 V +2 Expert +202 −1125 updated 01/30/22, 18:03

Commit message

Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */

The patch fixes this in all tests: getMock() and
createMock() need no annotation at all (both phpstan and
phpstorm understand this), getAccessibleMock() currently
needs an annotation and then sometimes mumbles about
obsolete arguments for _call(), which can be adapted
with another patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 37

Show 17 more files