Review main Merged

73231[TASK] Avoid phpstan 'PHPDoc tag @param has invalid value' errors

Stefan Bürk CR +2 V +2 Hard +49 −633 updated 01/30/22, 21:25

Commit message

Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */

But should be (at least):
/** @param MyType $foo */

Using argument typehints are the preferred solution.
'@param' docblock annotations are removed if argument
type hints can be set or has been already set.

Two test classes with broken syntax are added to
phpstan exclude configuration as this is for testing
purposes and can not be disabled otherwise.
Having them as ignore patterns should be avoided.

Generated baseline with:
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 37

Show 17 more files