Review 11.5 Merged

73232[TASK] Update doc comment for ActionController::getErrorFlashMessage

Christian Kuhn CR +2 V +2 Easy +1 −6 updated 01/30/22, 21:35

Commit message

The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool as allowed
return type in the doc comment.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 01/30/22, 21:18

  2. Christian Kuhn uploaded patch set 2 01/30/22, 21:19

  3. core-ci voted on patch set 1 V +1 01/30/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22749

  4. core-ci voted on patch set 2 V +1 01/30/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22750

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 01/30/22, 21:35

  6. Christian Kuhn merged patch set 3 01/30/22, 21:35