Review main Merged

73241[TASK] Fix definition availability checks in DI compiler passes

Benjamin Franzke CR +2 V +2 Normal +23 −102 updated 01/31/22, 09:08

Commit message

findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an alternative
$container->hasDefintion may be used to check for definition availability.

Also adapt the corresponding dashboard test.

Executed commands:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5