Review main Merged

73242[TASK] Harden event listener automagic parameter type resolution

Benjamin Franzke CR +2 V +2 Easy +1 −6 updated 01/31/22, 11:00

Commit message

Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
only this subclass of ReflectionType defines the getName() method.

[1] https://www.php.net/manual/en/class.reflectionnamedtype.php

Commands executed:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1213

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 08:00

  2. Benjamin Franzke rebased onto patch set 2 01/31/22, 08:25

  3. Benjamin Franzke marked it work in progress 01/31/22, 08:28

  4. Benjamin Franzke commented on patch set 2 01/31/22, 08:28

  5. core-ci voted on patch set 2 V +1 01/31/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22780

  6. Benjamin Franzke commented on patch set 2 01/31/22, 09:08

    This change is ready for review.
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/31/22, 10:09

  8. Oliver Klee voted on patch set 2 CR +1 01/31/22, 10:22

  9. Benni Mack voted on patch set 2 V +1 CR +1 01/31/22, 10:52

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 01/31/22, 10:55

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 01/31/22, 10:56

  12. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/31/22, 11:00

  13. Benjamin Franzke merged patch set 3 01/31/22, 11:00