Review main Merged

73245[TASK] Remove broken test from ServiceProviderCompilationPassTest

Benjamin Franzke CR +2 V +2 Easy +0 −38 updated 01/31/22, 12:07

Commit message

PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, which went undetected as the expected TypeError
was thrown for the invalid test setup.

This could have been fixed but the test actually only
tried to assert whether a callable type declaration is set,
in order to test whether a PHP error is thrown when an
invalid factory is provided. This is useless as such
factory will result in an error once called anyway.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2