Review 11.5 Merged

73248[TASK] Harden event listener automagic parameter type resolution

Benjamin Franzke CR +2 V +2 Easy +1 −6 updated 01/31/22, 11:42

Commit message

Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
only this subclass of ReflectionType defines the getName() method.

[1] https://www.php.net/manual/en/class.reflectionnamedtype.php

Commands executed:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Benjamin Franzke uploaded patch set 1 01/31/22, 11:01

  2. Oliver Klee voted on patch set 1 CR +1 01/31/22, 11:07

  3. core-ci voted on patch set 1 V -1 01/31/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22791

  4. core-ci voted on patch set 1 V +1 01/31/22, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22791

  5. Benjamin Franzke merged patch set 2 01/31/22, 11:42