Review main Merged

73252[TASK] Replace method clone with 'GeneralUtility::removeDotsFromTS()'

Stefan Bürk CR +2 V +2 Normal +3 −77 updated 02/01/22, 08:35

Commit message

'EditDocumentController::parseAdditionalGetParameters()'
was implemented to remove dots from key identifiers in
TypoScript array. Using 'callByRef' as parameter argument
should be avoided and is harder to mock and test properly.

This patch replaces this method with the well covered public
'GeneralUtility::removeDotsFromTS()', which is a safe drop-in
replacement. This eliminates the only usage, thus method is
removed along with the corresponding test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1314

  1. Stefan Bürk uploaded patch set 1 01/31/22, 20:25

  2. Stefan Bürk updated the commit message in patch set 2 01/31/22, 20:27

  3. Stefan Bürk uploaded patch set 3 01/31/22, 20:30

  4. Stefan Bürk updated the commit message in patch set 4 01/31/22, 20:36

  5. Stefan Bürk updated the commit message in patch set 5 01/31/22, 20:42

  6. Stefan Bürk updated the commit message in patch set 6 01/31/22, 20:43

  7. Stefan Bürk updated the commit message in patch set 7 01/31/22, 20:45

  8. Stefan Bürk updated the commit message in patch set 8 01/31/22, 20:45

  9. core-ci voted on patch set 8 V +1 01/31/22, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22828

  10. Christian Kuhn voted on patch set 8 V +1 CR +1 01/31/22, 20:59

  11. Wouter Wolters voted on patch set 8 V +1 CR +1 01/31/22, 22:45

  12. Christian Kuhn voted on patch set 8 V +2 CR +2 01/31/22, 23:27

  13. Christian Kuhn merged patch set 9 01/31/22, 23:27

  14. Benni Mack commented on patch set 9 02/01/22, 08:35

    hahah. nice one!