Review main Merged

73253[TASK] Have variadic typehints in ExpressionBuilder

Stefan Bürk CR +2 V +2 Normal +3 −112 updated 02/05/22, 12:04

Commit message

The patch adds proper typehints for 'andX()' and 'orX()'
of core 'ExpressionBuilder()' facade implementation.
This eliminates the need to have ignore rules for static
code analizers like phpstan.

Some consumers still pass invalid types to these methods,
these can be fixed with further patches and pave the way
towards additional PHP 8.1 based method signature work.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3