Review 11.5 Merged

73299[TASK] Remove superfluous elseif condition check in TcaPreparation

Christian Kuhn CR +2 V +2 Easy +8 −18 updated 02/05/22, 08:57

Commit message

phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.

This patch eliminates the superfluous condition by replacing
the condition with a nested inner condition. This makes phpstan
happy and removes one entry from the phpstan baseline file.

used commands:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2