73316[TASK] Convert IconFactoryTest to functional test
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1822
-
Nikita Hovratov uploaded patch set 1 02/06/22, 13:43
-
core-ci voted on patch set 1 V +1 02/06/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23097
-
Stefan Bürk uploaded patch set 2 02/06/22, 14:05
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/06/22, 14:05
-
core-ci voted on patch set 2 V +1 02/06/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23098
-
Oliver Klee commented on patch set 2 02/06/22, 14:30
-
Nikita Hovratov commented on patch set 2 02/06/22, 14:38
IconFactoryTest.php:437ReplyThis does not work unfortunately. The container is not available at the setUp stage. -
Nikita Hovratov commented on patch set 2 02/06/22, 14:40
IconFactoryTest.php:437Replynevermind, forgot the parent:setUp call, it works! -
Nikita Hovratov uploaded patch set 3 02/06/22, 14:41
-
Nikita Hovratov commented on patch set 3 02/06/22, 14:42
IconFactoryTest.php:437ReplyDone -
Stefan Bürk commented on patch set 3 02/06/22, 14:50
Should we do this as 11.5 backport ? So further changes in tests are "easier" to backport also ? -
core-ci voted on patch set 3 V +1 02/06/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23099
-
Nikita Hovratov commented on patch set 3 02/06/22, 14:53
Reply
good point, will add. -
Nikita Hovratov uploaded patch set 4 02/06/22, 14:54
-
Nikita Hovratov uploaded patch set 5 02/06/22, 14:56
-
core-ci voted on patch set 5 V +1 02/06/22, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23101
-
Oliver Klee voted on patch set 5 V +1 CR +1 02/06/22, 15:27
-
Stefan Bürk commented on patch set 5 V +1 CR +1 02/06/22, 15:44
Tested and verified 11.5 backport (manually). Minor merge-conflict, but easy solveable. -
Nikita Hovratov commented on patch set 5 02/06/22, 15:53
Reply
thank you! -
Georg Ringer voted on patch set 5 V +1 CR +1 02/07/22, 06:52
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/07/22, 08:35
-
Christian Kuhn merged patch set 6 02/07/22, 08:35
IconFactoryTest.php:437