Review main Merged

73323[TASK] Streamline LinkBrowser controller

Nikita Hovratov CR +2 V +2 Hard +214 −381 updated 02/07/22, 22:00

Commit message

- Use native typehints instead of doctype
- Add return types
- Use strict types
- Use DI: abstract class uses inject* methods,
  inheriting classes use constructor DI
- Improve array annotations for phpstan level 6
  (not yet detected)
- Remove method comments with no added value
- Use str_starts_with
- Move abstract and public methods to the top

Some minor refactorings along the way:
Get "richtextConfiguration" directly from parameters
array in BrowseLinksController.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4