Review main Merged

73337[DOCS] Mention "PackageArtifact.php" in Changelog entry

Lina Wolf CR +2 V +2 Easy +6 −0 updated 11/20/22, 14:30

Commit message

This enables developers to search for "PackageArtifact" in the changelog and documentation search.

References: https://github.com/TYPO3-Documentation/T3DocTeam/issues/177

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Georg Ringer +1
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1721

  1. Lina Wolf uploaded patch set 1 02/07/22, 16:45

  2. Mathias Brodala commented on patch set 1 CR -1 02/07/22, 16:49

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20

    Composer

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20

    the artifact is located at

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21

    will be

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22

    a TYPO3v11 sprint

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22

    together will all other Composer dependencies.

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22

    was located at

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23

    caused

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23

    did need

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24

    , which where solved by storing it
  3. core-ci voted on patch set 1 V +1 02/07/22, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23155

  4. Lina Wolf uploaded patch set 2 02/07/22, 18:05

  5. Lina Wolf commented on patch set 2 02/07/22, 18:07

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24 Reply

    Done
  6. core-ci voted on patch set 2 V +1 02/07/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23158

  7. Nikita Hovratov commented on patch set 2 02/07/22, 18:28

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22

    with

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24

    was solved
  8. Lina Wolf uploaded patch set 3 02/07/22, 19:23

  9. Lina Wolf commented on patch set 3 02/07/22, 19:23

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22 Reply

    Done

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24 Reply

    some issues [...] which were solved
  10. core-ci voted on patch set 3 V +1 02/07/22, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23162

  11. Mathias Brodala commented on patch set 3 02/08/22, 07:43

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24 Reply

    Done
  12. Mathias Brodala voted on patch set 3 CR +1 02/08/22, 07:43

  13. Georg Ringer commented on patch set 3 02/09/22, 12:27

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21

    shouldnt this be "must". TYPO3 itself doesn't deploy anything
  14. Mathias Brodala commented on patch set 3 02/09/22, 12:29

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21 Reply

    Yes and no. This text assumes that you deploy the "vendor" directory, otherwise you'd have a broken instance. In this case the file is deployed automatically. But yes, a simple change to "must" drops this implied workflow. (Then without "automatically")
  15. Georg Ringer commented on patch set 4 02/09/22, 12:35

    Published edit on patch set 3.
  16. Georg Ringer voted on patch set 4 V +1 CR +1 02/09/22, 12:35

  17. core-ci voted on patch set 4 V +1 02/09/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23282

  18. Mathias Brodala commented on patch set 4 V +1 CR +1 02/10/22, 09:40

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21 Reply

    Done
  19. Lina Wolf commented on patch set 4 V +2 CR +2 02/10/22, 09:41

    has +1 vom core merger and one other
  20. Lina Wolf merged patch set 5 02/10/22, 09:41

  21. Christian Kuhn commented on patch set 5 11/20/22, 14:30