Review 11.5 Merged

73364[BUGFIX] Consider spamProtectEmailAddresses markup in <f:link.email>

Oliver Hader CR +2 V +2 Easy +19 −17 updated 02/14/22, 09:03

Commit message

Email processing in <f:link.email> view helper has been changed to
be based on typolink recently. In order to allow (internal) markup
in spamProtectEmailAddresses_atSubst or ~_lastDotSubst it has to be
ensured that only the input parameter (the email address) is
considered as user input and thus encoded for HTML.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 02/08/22, 19:39

  2. Oliver Hader voted on patch set 1 CR -1 02/08/22, 19:43

  3. core-ci voted on patch set 1 V +1 02/08/22, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23235

  4. Oliver Hader uploaded patch set 2 02/09/22, 08:49

  5. core-ci voted on patch set 2 V +1 02/09/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23262

  6. Benni Mack voted on patch set 2 V +1 CR +1 02/09/22, 09:19

  7. Oliver Hader voted on patch set 2 CR -2 02/11/22, 13:30

  8. Oliver Hader uploaded patch set 3 02/11/22, 13:51

  9. Oliver Hader voted on patch set 3 CR 0 02/11/22, 13:51

  10. core-ci voted on patch set 3 V +1 02/11/22, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23395

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 02/11/22, 14:41

  12. Benni Mack voted on patch set 3 V +2 CR +2 02/14/22, 09:03

  13. Benni Mack merged patch set 4 02/14/22, 09:03