Review main Merged Breaking

73366[!!!][FEATURE] Override any backend template with TsConfig

Christian Kuhn CR +2 V +2 Nightmare +1422 −1491 updated 02/11/22, 13:19

Commit message

This patch finishes the migration to the new backend
templating strategy. Affected are the backend page
module and the dashboard extension:

* Bigger refactoring of PageLayoutController
  towards more modern and streamlined code with
  much less class state.
* Transition of fillDefaultsByPackageName() in
  the page module for the "grid" layout towards
  TsConfig based template overrides.
* Refactoring of the dashboard main controller
  to avoid fillDefaultsByPackageName().

The new template override API based on TsConfig
is now documented with a feature ReST file. The
new template override strategy is breaking for
existing overrides based on FE TypoScript and
documented with a breaking ReST file including
a detailed migration path. The ext:dashboard
documentation is adapted accordingly.

As a result, all backend controllers that do not
rely on extbase no longer parse FE TypoScript.
This is especially useful for the central page
module: Clicking around on a v12 bootstrap_package
page tree in the page module without the patch leads
to around 80 to 120 milliseconds parsetime on my
machine - depending on the number and complexity
of content elements and the cache state. This
systematically shrinks to around 50 to 70 milliseconds
with the patch: The system no longer loads tons of
extbase related classes, dependency injection is more
effective, and the entire FE TypoScript parsing is gone.
With cold caches ("Flush all caches" backend button),
the difference is around 100 milliseconds for the
first call on my system - in general, the bigger the
instance, the higher the improvement.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 43

Show 23 more files