Review main Merged

73374[TASK] Use factory method for generating preview urls

Oli Bartsch CR +2 V +2 Easy +5 −7 updated 02/09/22, 10:50

Commit message

This is a followup for #96777, which uses the
factory method instead of instantiating the
PreviewUriBuilder via makeInstance().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 45

  1. Oli Bartsch uploaded patch set 1 02/09/22, 10:23

  2. core-ci voted on patch set 1 V +1 02/09/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23273

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/09/22, 10:49

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/09/22, 10:50

  5. Benni Mack merged patch set 2 02/09/22, 10:50