Review main Merged

73381[BUGFIX] Add missing grid configuration for form elements

Justus Moroni CR +2 V +2 Normal +206 −0 updated 04/16/25, 12:15

Commit message

The gridcolumn viewport configuration for the form elements
`StaticText` and `ContentElement` are added now.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2533

Show 68 earlier messages
  1. Justus Moroni uploaded patch set 1 02/09/22, 17:36

  2. core-ci voted on patch set 1 V +1 02/09/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23295

  3. Justus Moroni updated the commit message in patch set 2 02/09/22, 17:49

  4. Justus Moroni commented on patch set 2 02/09/22, 17:52

    This is only the fix for the number form element editor. As I've said in the ticket, we need to check if the "static text" and "contentelement" form elements also need the grid column viewport configurator.
  5. core-ci voted on patch set 2 V +1 02/09/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23296

  6. Nikita Hovratov commented on patch set 2 02/11/22, 18:53

    Reply

    Nice catch! Yes, please add them for static text and contentelement, too. And I think backport for v10 is not necessary, as it's not a critical bug.
  7. waldhacker uploaded patch set 3 02/26/22, 18:21

  8. waldhacker commented on patch set 3 02/26/22, 18:23

    Reply

    Done
  1. waldhacker voted on patch set 3 V +1 CR +1 02/26/22, 18:23

  2. core-ci voted on patch set 3 V +1 02/26/22, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24340

  3. Björn Jacob updated the commit message in patch set 4 03/04/22, 15:25

  4. Björn Jacob commented on patch set 4 CR -1 03/04/22, 15:29

    I am not sure about this patch. It is similar to https://review.typo3.org/c/Packages/TYPO3.CMS/+/73691. In this case, we decided to juggle those fields around in v13 and have a deprecation in v12. This patch over here adds new keys within the YAML configuration. People having those keys already in use want see the improvement. I think, having this in v12 only including a "Important.rst" or a "Breaking.rst" would be better. What do you guys think?
  5. core-ci voted on patch set 4 V +1 03/04/22, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24564

  6. Elias Häußler commented on patch set 4 04/28/22, 08:39

    Reply

    I agree with Björn. Adding new keys or moving keys around is imho a breaking change. In order to align those changes with previous changes, we should: - Deprecate old keys if they should be moved and then move them around in v13 (since people might reference those keys in various ways, which was the argument in https://review.typo3.org/c/Packages/TYPO3.CMS/+/73691 as well) - Add new config together with a Breaking.rst, targeting main only What do you think?
  7. waldhacker commented on patch set 4 04/28/22, 08:42

    Reply

    Fine for me
  8. Björn Jacob updated the commit message in patch set 5 06/29/22, 07:52

  9. Björn Jacob voted on patch set 5 CR -1 06/29/22, 07:52

  10. core-ci voted on patch set 5 V -1 06/29/22, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28468

  11. Justus Moroni uploaded patch set 6 08/08/22, 16:56

  12. core-ci voted on patch set 6 V +1 08/08/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29958

  13. Justus Moroni commented on patch set 6 08/08/22, 17:05

    I have rebased from main and fixed the merge conflicts. The changes to the yaml and rst files are due to https://forge.typo3.org/issues/97517
  14. Benni Mack updated the commit message in patch set 7 V +1 05/03/23, 09:21

  15. core-ci voted on patch set 7 V -1 05/03/23, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41398

  16. Benni Mack updated the commit message in patch set 8 V -1 10/18/24, 14:06

  17. Benni Mack wrote 03/28/25, 09:47

    Topic set to form
  18. Benni Mack marked it work in progress 03/28/25, 09:49

  19. Benjamin Kott uploaded patch set 9 04/16/25, 11:45

  20. Benjamin Kott commented on patch set 9 04/16/25, 11:45

    This change is ready for review.
  21. Benjamin Kott commented on patch set 9 04/16/25, 11:47

    Reply

    This cannot be considered a problem, the configuration is for base elements and can be considered as static internal API.

    Reply

    Done
  22. core-ci voted on patch set 9 V +1 04/16/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77834

  23. Andreas Kienast voted on patch set 9 CR +1 V +1 04/16/25, 12:05

  24. Benjamin Kott voted on patch set 9 CR +2 V +2 04/16/25, 12:06

  25. Benjamin Kott merged patch set 10 04/16/25, 12:15