Review main Merged

73388[TASK] Simplify NewContentElementController view rendering

Christian Kuhn CR +2 V +2 Normal +92 −97 updated 02/11/22, 13:09

Commit message

The NewContentElementController (+content button in page
or list) view handling is odd: The single items are
rendered with a view. Those are channeled through
ModuleTemplate->getDynamicTabMenu() which creates
another view to render the 'tab' panel. That panel
is then put into a third view to render the rest
of the modal content.

The patch streamlines this by avoiding getDynamicTabMenu()
and putting all needed variables into one view instance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2228

Show 23 earlier messages
  1. Christian Kuhn uploaded patch set 1 02/10/22, 16:28

  2. core-ci voted on patch set 1 V +1 02/10/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23335

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/10/22, 20:04

  1. Benjamin Franzke commented on patch set 1 CR -1 02/10/22, 20:36

    NewContentElementController.php:131

    We don't need to create an empty stream here. A stream is allocating lazily if needed. Just invoke: return $this->responseFactory->createResponse();
  2. Christian Kuhn uploaded patch set 2 02/10/22, 20:45

  3. Christian Kuhn commented on patch set 2 02/10/22, 20:46

    NewContentElementController.php:131 Reply

    Done. Thx.
  4. core-ci voted on patch set 2 V +1 02/10/22, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23354

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 02/10/22, 20:57

  6. Benni Mack voted on patch set 2 CR +1 02/11/22, 06:21

  7. Benjamin Franzke commented on patch set 2 CR -1 02/11/22, 08:47

    NewContentElementController.php:243

    text/html; charset=utf-8 Content-Type missing We should really let BackendViewFactory return a ResponsableViewInterface.
  8. Christian Kuhn commented on patch set 2 02/11/22, 09:24

    NewContentElementController.php:243 Reply

    i'll go back to htmlResponse for now, this part was scope-creep anyway.
  9. Christian Kuhn uploaded patch set 3 02/11/22, 09:32

  10. Christian Kuhn commented on patch set 2 02/11/22, 09:32

    NewContentElementController.php:243 Reply

    Done
  11. core-ci voted on patch set 3 V +1 02/11/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23366

  12. Oli Bartsch commented on patch set 3 02/11/22, 10:17

    NewContentElementController.php:218

    This is always true at this point

    Wizard.html:5

    Can be omitted now.
  13. Christian Kuhn uploaded patch set 4 02/11/22, 12:21

  14. Christian Kuhn commented on patch set 4 02/11/22, 12:21

    NewContentElementController.php:218 Reply

    Done

    Wizard.html:5 Reply

    Done
  15. Christian Kuhn commented on patch set 4 02/11/22, 12:22

    NewContentElementController.php:126

    ===
  16. Christian Kuhn uploaded patch set 5 02/11/22, 12:23

  17. core-ci voted on patch set 4 V +1 02/11/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23384

  18. core-ci voted on patch set 5 V +1 02/11/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23385

  19. Oli Bartsch uploaded patch set 6 02/11/22, 12:52

  20. Oli Bartsch voted on patch set 6 V +1 CR +1 02/11/22, 12:52

  21. Stefan Bürk voted on patch set 6 V +1 CR +1 02/11/22, 13:03

  22. core-ci voted on patch set 6 V +1 02/11/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23389

  23. Christian Kuhn voted on patch set 6 V +2 CR +2 02/11/22, 13:08

  24. Christian Kuhn commented on patch set 6 02/11/22, 13:09

    thx!
  25. Christian Kuhn merged patch set 7 02/11/22, 13:09