73388[TASK] Simplify NewContentElementController view rendering
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2228
Show 23 earlier messages
-
Christian Kuhn uploaded patch set 1 02/10/22, 16:28
-
core-ci voted on patch set 1 V +1 02/10/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23335
-
Stefan Bürk voted on patch set 1 V +1 CR +1 02/10/22, 20:04
-
Benjamin Franzke commented on patch set 1 CR -1 02/10/22, 20:36
-
Christian Kuhn uploaded patch set 2 02/10/22, 20:45
-
Christian Kuhn commented on patch set 2 02/10/22, 20:46
NewContentElementController.php:131ReplyDone. Thx. -
core-ci voted on patch set 2 V +1 02/10/22, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23354
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/10/22, 20:57
-
Benni Mack voted on patch set 2 CR +1 02/11/22, 06:21
-
Benjamin Franzke commented on patch set 2 CR -1 02/11/22, 08:47
NewContentElementController.php:243text/html; charset=utf-8 Content-Type missing We should really let BackendViewFactory return a ResponsableViewInterface. -
Christian Kuhn commented on patch set 2 02/11/22, 09:24
NewContentElementController.php:243Replyi'll go back to htmlResponse for now, this part was scope-creep anyway. -
Christian Kuhn uploaded patch set 3 02/11/22, 09:32
-
Christian Kuhn commented on patch set 2 02/11/22, 09:32
NewContentElementController.php:243ReplyDone -
core-ci voted on patch set 3 V +1 02/11/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23366
-
Oli Bartsch commented on patch set 3 02/11/22, 10:17
NewContentElementController.php:218This is always true at this pointWizard.html:5Can be omitted now. -
Christian Kuhn uploaded patch set 4 02/11/22, 12:21
-
Christian Kuhn commented on patch set 4 02/11/22, 12:21
NewContentElementController.php:218ReplyDoneWizard.html:5ReplyDone -
Christian Kuhn commented on patch set 4 02/11/22, 12:22
NewContentElementController.php:126=== -
Christian Kuhn uploaded patch set 5 02/11/22, 12:23
-
core-ci voted on patch set 4 V +1 02/11/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23384
-
core-ci voted on patch set 5 V +1 02/11/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23385
-
Oli Bartsch uploaded patch set 6 02/11/22, 12:52
-
Oli Bartsch voted on patch set 6 V +1 CR +1 02/11/22, 12:52
-
Stefan Bürk voted on patch set 6 V +1 CR +1 02/11/22, 13:03
-
core-ci voted on patch set 6 V +1 02/11/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23389
-
Christian Kuhn voted on patch set 6 V +2 CR +2 02/11/22, 13:08
-
Christian Kuhn commented on patch set 6 02/11/22, 13:09
thx! -
Christian Kuhn merged patch set 7 02/11/22, 13:09
NewContentElementController.php:131