Review main Abandoned

73458[BUGFIX] Unify view page allowed behaviour

Nikita Hovratov CR 0 V 0 Hard +165 −202 updated 07/29/23, 21:09

Commit message

The whole "Can I have a page preview" behaviour was
completely scattered around multiple classes and was
duplicated over and over again, sometimes with
missing conditions.

This led to PHP warnings in various views, when e.g.
a page of doktype "recycler" was currently selected
in the pagetree.

The behaviour is now extracted into the class
PagePreviewAbility. It takes a page record as a
constructor argument or alternatively a page uid for
the factory method createWithPageUid.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13