Review main Merged

73459[TASK] Allow in-memory caching of HTML sanitizer behavior

Oliver Hader CR +2 V +2 Normal +83 −3 updated 02/26/22, 09:00

Commit message

DefaultSanitizerBuilder for HTML sanitizer creates a new behavior
for each invocation which is superfluous and can be cached in memory.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oliver Hader uploaded patch set 1 02/12/22, 20:38

  2. Benni Mack voted on patch set 1 V +1 CR +1 02/12/22, 20:46

  3. core-ci voted on patch set 1 V +1 02/12/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23469

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/12/22, 21:32

  5. Oliver Hader voted on patch set 1 CR -1 02/13/22, 09:30

  6. Oliver Hader commented on patch set 1 02/13/22, 09:32

    Just realized that documentations has examples to override/extend the behavior, e.g. https://docs.typo3.org/c/typo3/cms-core/9.5/en-us/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.html#php-api This might lead to new side effects using the current approach...
  7. Oliver Hader uploaded patch set 2 02/13/22, 10:06

  8. core-ci voted on patch set 2 V +1 02/13/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23475

  9. Benni Mack voted on patch set 2 V +1 CR +1 02/15/22, 09:10

  10. Oliver Hader voted on patch set 2 V +2 CR +2 02/26/22, 09:00

  11. Oliver Hader merged patch set 3 02/26/22, 09:00