Review main Abandoned

73469[BUGFIX] Prevent undefined array key in ContentObjectRenderer

Georg Ringer CR 0 V 0 Easy +1 −1 updated 02/14/22, 19:28

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Georg Ringer uploaded patch set 1 02/14/22, 09:52

  2. Georg Ringer commented on patch set 1 02/14/22, 09:52

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/14/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23497

  4. Oli Bartsch commented on patch set 1 CR -1 02/14/22, 10:24

    In which situation does this occur? AFAIK empty() does not trigger any warnings for undefined array key access (https://3v4l.org/DBqAh).
  5. Christian Kuhn commented on patch set 1 CR -1 02/14/22, 10:57

    ContentObjectRenderer.php:5862 Unresolved

    that's useless - empty() does not emit notices / warnings.
  6. Georg Ringer abandoned the change 02/14/22, 19:28