Review main Merged

73483[TASK] Streamline TSFE-related config properties

Benni Mack CR +2 V +2 Easy +11 −22 updated 02/18/22, 08:35

Commit message

Some default properties in TypoScript have
been modified back then with the TypoScript
condition [compatVersion > 4.0] which has been
removed years ago.

This code replaces the leftover functionality
and explicitly checks the occurrences with default
values.

In addition, the more performant "array_replace_recursive"
function is used for the page.config merging.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Benni Mack uploaded patch set 1 02/14/22, 17:43

  2. core-ci voted on patch set 1 V -1 02/14/22, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23543

  3. Benni Mack uploaded patch set 2 02/14/22, 18:58

  4. core-ci voted on patch set 2 V +1 02/14/22, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23550

  5. Christian Kuhn commented on patch set 2 CR -1 02/14/22, 21:28

    not sure. at least need slightly more info, i guess.

    DefaultJavaScriptAssetTrait.php:60

    sure here? this means method now returns 'true' if TSFE is sot set.

    TypoScriptFrontendController.php:1712

    sure? ArrayUtility::mergeRecursiveWithOverrule() has this odd '__unset' behavior.

    TypoScriptFrontendController.php:1717

    same question here.
  6. Benni Mack commented on patch set 2 02/14/22, 22:06

    TypoScriptFrontendController.php:1712 Reply

    I think for TypoScript, people use config.myOption > as this is the one documented.

    TypoScriptFrontendController.php:1717 Reply

    I think people should use "config.myOption >" instead.
  7. Benni Mack commented on patch set 2 02/14/22, 22:08

    DefaultJavaScriptAssetTrait.php:60 Reply

    Then it should be $frontendController?->config otherwise it should fatal.
  8. Christian Kuhn commented on patch set 2 02/15/22, 09:08

    TypoScriptFrontendController.php:1712 Reply

    Ack

    TypoScriptFrontendController.php:1717 Reply

    Ack
  9. Benni Mack uploaded patch set 3 02/15/22, 15:09

  10. Benni Mack commented on patch set 3 02/15/22, 15:09

    solved your remarks

    DefaultJavaScriptAssetTrait.php:60 Reply

    Done
  11. core-ci voted on patch set 3 V +1 02/15/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23632

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 02/18/22, 00:49

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 02/18/22, 08:35

  14. Christian Kuhn merged patch set 4 02/18/22, 08:35