73485[!!!][TASK] Allow only Resources/Public in getPublicResourceWebPath()
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 4
Files 7
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+0 −3
- typo3/sysext/core/Classes/Utility/PathUtility.php+3 −13
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96107-DeprecatedFunctionalityRemoved.rst2+4 −0
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityPublicPathsTest.php+3 −3
- typo3/sysext/core/Tests/UnitDeprecated/Utility/PathUtilityPublicPathsTest.phpdeleted+0 −112
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php+1 −2
- typo3/sysext/frontend/Tests/UnitDeprecated/Resource/FilePathSanitizerTest.php3deleted+0 −36
Review log 1619
-
Christian Kuhn uploaded patch set 1 02/14/22, 18:52
-
core-ci voted on patch set 1 V +1 02/14/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23547
-
Christian Kuhn uploaded patch set 2 02/14/22, 19:16
-
core-ci voted on patch set 2 V +1 02/14/22, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23552
-
Helmut Hummel commented on patch set 2 CR -1 02/14/22, 20:06
Thanks for looking into this. However getting rid of these deprecations involves quite a bit more of code refactoring unfortunately. I'd even maybe start with completely new API, that deals with extension resources as objects, before stripping down the string based resource APIFilePathSanitizerTest.php:31To remove this functionality, usage of the FilePathSanitizer in places where it used to resolve private resource paths must be removed first -
Christian Kuhn commented on patch set 2 02/14/22, 20:56
FilePathSanitizerTest.php:31Replyhmm. There is no more deprecated code involved as far as i can see. So we could change FilePathSanitizer() and move the test from UnitDeprecated/ to Unit/ somehowe? can you help here? I'm mostly concerned about the PathUtility method ... -
Helmut Hummel commented on patch set 2 02/15/22, 09:58
FilePathSanitizerTest.php:31Reply UnresolvedI have no opinion on where to move tests. The issue here is, that the FilePathSanitizer is used to generate relative paths also for accessing private resource files (not only for URLs). This means, the usage of this class must be removed in general, because it implements a broken concept. -
Simon Schaufelberger commented on patch set 2 09/24/22, 23:13
Unresolved
can this make it into v12? -
Kevin Appelt commented on patch set 2 10/02/22, 11:26
Breaking-96107-DeprecatedFunctionalityRemoved.rst:393"and named as" -
Georg Ringer uploaded patch set 3 10/02/22, 18:14
-
Georg Ringer commented on patch set 3 10/02/22, 18:15
Breaking-96107-DeprecatedFunctionalityRemoved.rst:393ReplyDone -
core-ci voted on patch set 3 V +1 10/02/22, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31902
-
Benni Mack commented on patch set 3 CR -1 05/03/23, 09:23
Releases line missing -
Simon Schaufelberger commented on patch set 3 01/04/24, 01:29
Unresolved
let's get this finished for v13! -
Christian Kuhn commented on patch set 3 01/08/24, 11:34
afaik, helmuts comment "To remove this functionality, usage of the FilePathSanitizer in places where it used to resolve private resource paths must be removed first" is still valid. -
Simon Schaufelberger commented on patch set 3 01/25/24, 14:19
Reply
@lolli@schwarzbu.ch will this patch make it for v13? -
Christian Kuhn commented on patch set 3 01/25/24, 14:33
Reply
Simon. Please stop this. Read the previous comment: The patch is not ready and blocked. -
Christian Kuhn commented on patch set 3 12/17/24, 11:13
Unresolved
hey. it is still very unclear on how to continue with these path issues. We have this patch for 2.5 years now and it seems it needs more underlying refactoring before the method can be removed. the existing trigger_error() within the method does not really hurt much at the moment. i'm gonna abandon the change for now, it could be picked up again if work continues and if the removal becomes feasible. -
Christian Kuhn abandoned the change 12/17/24, 11:13