Review main Merged

73486[TASK] Move functionality if a page is hidden from TSFE to PageRepository

Benni Mack CR +2 V +2 Normal +85 −69 updated 02/14/22, 21:58

Commit message

TSFE contains a lot of functionality which
is rather related to other places.

One of them is the protected method
"determineIdIsHidden" which is now
transferred to PageRepository where all
other methods related to this logic is kept.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1318

  1. Benni Mack uploaded patch set 1 02/14/22, 18:55

  2. core-ci voted on patch set 1 V -1 02/14/22, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23549

  3. Benni Mack uploaded patch set 2 02/14/22, 20:07

  4. core-ci voted on patch set 2 V +1 02/14/22, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23559

  5. Benni Mack commented on patch set 3 02/14/22, 20:27

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 02/14/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23562

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 02/14/22, 21:12

  8. Christian Kuhn commented on patch set 3 02/14/22, 21:32

    PageRepository.php:1819

    now context is being clone twice: here and in caller. intended?
  9. Christian Kuhn uploaded patch set 4 02/14/22, 21:35

  10. Christian Kuhn commented on patch set 4 CR -1 02/14/22, 21:35

    PageRepository.php:1820

    having context both as property and as argument is confusing here. could we maybe resolve this somehow? and resetting $this->context to the incoming $context ...
  11. Benni Mack commented on patch set 4 02/14/22, 21:36

    on it
  12. Benni Mack uploaded patch set 5 02/14/22, 21:39

  13. core-ci voted on patch set 4 V +1 02/14/22, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23567

  14. core-ci voted on patch set 5 V +1 02/14/22, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23569

  15. Benni Mack commented on patch set 5 02/14/22, 21:55

    PageRepository.php:1819 Reply

    Done

    PageRepository.php:1820 Reply

    Done
  16. Stefan Bürk voted on patch set 5 V +1 CR +1 02/14/22, 21:58

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 02/14/22, 21:58

  18. Christian Kuhn merged patch set 6 02/14/22, 21:58