Review main Merged Breaking

73489[!!!][TASK] Use https as default scheme in PageRouter

Georg Ringer CR +2 V +2 Easy +33 −1 updated 02/16/22, 18:59

Commit message

Make the web more secure by using https as fallback scheme if not set.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Georg Ringer uploaded patch set 1 02/14/22, 19:48

  2. Georg Ringer commented on patch set 1 02/14/22, 19:49

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/14/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23556

  4. Oli Bartsch commented on patch set 1 02/14/22, 21:02

    Breaking-96835-HttpsAsDefaultSchemeInPageRouter.rst:12

    Since this is public API we should IMO mention the corresponding Class->Method.
  5. Georg Ringer uploaded patch set 2 02/15/22, 08:07

  6. core-ci voted on patch set 2 V +1 02/15/22, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23590

  7. Georg Ringer rebased onto patch set 3 02/16/22, 18:42

  8. Christian Kuhn commented on patch set 3 V +1 CR +1 02/16/22, 18:48

    Breaking-96835-HttpsAsDefaultSchemeInPageRouter.rst:12 Reply

    Done
  9. core-ci voted on patch set 3 V +1 02/16/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23743

  10. Benjamin Franzke voted on patch set 3 V +2 CR +2 02/16/22, 18:59

  11. Benjamin Franzke merged patch set 4 02/16/22, 18:59