73491[TASK] Cleanup code of ext:sys_note
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+3 −6
- typo3/sysext/sys_note/Classes/Hook/InfoModuleHook.php+1 −4
- typo3/sysext/sys_note/Classes/Provider/PageModuleProvider.php+1 −4
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.php+1 −4
- typo3/sysext/sys_note/Tests/Functional/Tca/NoteVisibleFieldsTest.php3+2 −2
Review log 1014
-
Georg Ringer uploaded patch set 1 02/14/22, 20:09
-
Georg Ringer commented on patch set 1 02/14/22, 20:09
This change is ready for review. -
core-ci voted on patch set 1 V -1 02/14/22, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23560
-
Chris Müller commented on patch set 1 02/14/22, 20:37
NoteVisibleFieldsTest.php:29The annotation can then be removed (or use "@var list<string>") -
Georg Ringer rebased onto patch set 2 02/15/22, 07:40
-
core-ci voted on patch set 2 V +1 02/15/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23588
-
Nikita Hovratov commented on patch set 2 02/15/22, 08:12
NoteVisibleFieldsTest.php:29ReplyI think we mostly use "string[]" for this (same thing). -
Benni Mack commented on patch set 3 02/16/22, 22:24
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 02/16/22, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23760
-
Benni Mack uploaded patch set 4 02/17/22, 22:37
-
core-ci voted on patch set 4 V +1 02/17/22, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23841
-
Benni Mack commented on patch set 4 V +1 CR +1 02/17/22, 23:18
NoteVisibleFieldsTest.php:29ReplyDone -
Oli Bartsch voted on patch set 4 V +2 CR +2 02/17/22, 23:21
-
Oli Bartsch merged patch set 5 02/17/22, 23:21