Review main Abandoned

73494[WIP][TASK] Fix phpstan errors in GraphicalFunctions.php

Thomas Anders CR 0 V 0 Normal +53 −176 updated 06/11/23, 23:21

Commit message

Refactor the whole file, because resource is replaced by \GdImage since
PHP 8.0.0.

Fix some type errors in color functions that expects integers but got
floats.

WIP:
- Add parameter types to touched methods.
- A lot of cleanup and of course - more testing to be done.
- Update phpstan-baseline.neon

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 813

  1. Thomas Anders uploaded patch set 1 02/14/22, 21:06

  2. core-ci voted on patch set 1 V -1 02/14/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23566

  3. Thomas Anders uploaded patch set 2 02/16/22, 21:11

  4. core-ci voted on patch set 2 V -1 02/16/22, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23754

  5. Thomas Anders uploaded patch set 3 02/16/22, 21:50

  6. core-ci voted on patch set 3 V +1 02/16/22, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23758

  7. crell commented on patch set 3 05/12/22, 20:11

    Why not add return types if you're already adding param types?
  8. Simon Schaufelberger uploaded patch set 4 06/10/22, 12:44

  9. core-ci voted on patch set 4 V -1 06/10/22, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27921

  10. Simon Schaufelberger uploaded patch set 5 06/10/22, 13:06

  11. core-ci voted on patch set 5 V +1 06/10/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27925

  12. Christian Kuhn commented on patch set 5 06/11/23, 23:21

    hey. i hope it's ok to abandon here for now: the patch is stalled since first commit. let's push fresh patches if this topic is picked up.
  13. Christian Kuhn abandoned the change 06/11/23, 23:21