Review main Merged Breaking

73518[!!!][FEATURE] Avoid BackendTemplateView

Christian Kuhn CR +2 V +2 Expert +620 −552 updated 02/16/22, 20:10

Commit message

Class BackendTemplateView has been a temporary solution
to simplify the implementation of the "TsConfig template
override" feature into smaller patches.

With ModuleTemplate and general view works being mostly
done in the backend, BackendTemplateView should be
removed again.

The patch removes all usages switching nearly all views
to BackendViewFactory, which removes the explicit
dependency to Typo3Fluid ViewInterface since the
EXT:core ViewInterface is not directly bound to Fluid
anymore.

Using BackendViewFactory has the additional advantage
that templates which don't use ModuleTemplate because
they're hook usages or some other "sub-view", can now
be overridden with TsConfig, too.

Using BackendViewFactory also makes the dependency to
ServerRequestInterface explicit. The patch thus hands
$request around at some more places where $request was
only an indirect dependency before.

One special @todo area is FormEngine, which is unable
to have dependency injection (for BackendViewFactory)
due to its manual constructor arguments. The patch
falls back to Typo3Fluid TemplateView in those cases.
The FormEngine API should be adapted with another patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 74

Show 54 more files