73527[POC][!!!][FEATURE] Introduce CSS variables for FSC styling options
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 25
- Build/Gruntfile.js2+16 −2
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96939-IntroduceFluidStyledContentCssVariables.rst6new+41 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96939-IntroduceFluidStyledContentCssVariables.rst14new+60 −0
- typo3/sysext/fluid_styled_content/Build/Scss/gallery.scssnew+108 −0
- typo3/sysext/fluid_styled_content/Build/Scss/global.scssnew+90 −0
- typo3/sysext/fluid_styled_content/Build/Scss/headline.scssnew+12 −0
- typo3/sysext/fluid_styled_content/Build/Scss/table.scssnew+24 −0
- typo3/sysext/fluid_styled_content/Build/Scss/uploads.scssnew+24 −0
- typo3/sysext/fluid_styled_content/Classes/DataProcessor/StylesheetIncludedDataProcessor.phpnew+45 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript+4 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Styling/setup.typoscript+8 −78
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/constants.typoscript+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Layouts/Default.html+4 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Partials/Header/All.html+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Image.html+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Table.html+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Textmedia.html2+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Textpic.html+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/Uploads.html+3 −0
- typo3/sysext/fluid_styled_content/Resources/Public/Css/gallery.cssnew+13 −0
Show 5 more files
- typo3/sysext/fluid_styled_content/Resources/Public/Css/global.cssnew+13 −0
- typo3/sysext/fluid_styled_content/Resources/Public/Css/headline.cssnew+13 −0
- typo3/sysext/fluid_styled_content/Resources/Public/Css/table.cssnew+13 −0
- typo3/sysext/fluid_styled_content/Resources/Public/Css/uploads.cssnew+13 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php2+4 −1
Review log 2128
Show 23 earlier messages
-
Nikita Hovratov uploaded patch set 1 02/15/22, 19:22
-
Benjamin Franzke commented on patch set 1 02/15/22, 19:26
nice idea <3 -
core-ci voted on patch set 1 V -1 02/15/22, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23654
-
Benni Mack commented on patch set 1 02/15/22, 20:31
wow. nice! -
Nikita Hovratov uploaded patch set 2 02/17/22, 09:50
-
core-ci voted on patch set 2 V -1 02/17/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23778
-
Nikita Hovratov uploaded patch set 3 02/17/22, 10:03
-
core-ci voted on patch set 3 V +1 02/17/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23780
-
Stefan Bürk commented on patch set 3 02/18/22, 00:38
Textmedia.html:11Guessing this is a leftover. Shipped debug output is kinda weired.RequestHandler.php:407Can we please split this now in multilines after this is now a more nested and complex condition, or would do you think ? -
Nikita Hovratov uploaded patch set 4 02/18/22, 08:37
-
Nikita Hovratov commented on patch set 3 02/18/22, 08:37
Textmedia.html:11Replywhoops, that should not be thereRequestHandler.php:407ReplyDone -
core-ci voted on patch set 4 V +1 02/18/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23863
-
Chris Müller commented on patch set 4 02/18/22, 12:29
Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:4"CSS custom properties", see https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_propertiesBreaking-96939-IntroduceFluidStyledContentCssVariables.rst:14"CSS custom properties"Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:28HTMLFeature-96939-IntroduceFluidStyledContentCssVariables.rst:4I propose to use the offical name "CSS custom properties", perhaps with addition "variables" like in the MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_propertiesFeature-96939-IntroduceFluidStyledContentCssVariables.rst:13"CSS custom properties"Feature-96939-IntroduceFluidStyledContentCssVariables.rst:26SCSS filesFeature-96939-IntroduceFluidStyledContentCssVariables.rst:29SCSSFeature-96939-IntroduceFluidStyledContentCssVariables.rst:39seperate => separateFeature-96939-IntroduceFluidStyledContentCssVariables.rst:52"CSS custom properties"Feature-96939-IntroduceFluidStyledContentCssVariables.rst:55SCSS -
Stefan Bürk commented on patch set 4 02/18/22, 12:52
Generally I love this idea behind this patch, thus thanks for your work on this already Nikita. However I have to throw one think into the discussion pot: Generally Typo3 is really really conservative in client/browser requirements for the frontend, from the core side. Better to say, totally open. And leaving this to the agencies, integrators, projects etc what they want to use to deliver frontend content and for which devices, browsers and so on. With this patch using this CSS Variable thing the core puts "requirements" out for the frontend and cut the decision freedom down. At least if this default css is used. Yes, I know there is a breaking ReST file stating this, but I think we should really think a moment about it - and this should eventually be more prominently published then - otherwise we would have a bunch of questions about this in the slack chanells eventually. Don't get me wrong - not to block this, just to raise awarness if this point a little bit more. -
Nikita Hovratov commented on patch set 4 02/18/22, 13:25
Reply
Thanks for the feedback! I love to have a discussion. Yes, TYPO3 should not mandate, what to use for the frontend. I'm totally open to change this to an optional feature, as the optional CSS is already. Adding a new static template: "Fluid Styled Content Optional (CSS variables)" or so might be a good idea, and it's not breaking anymore. -
Stefan Bürk commented on patch set 4 02/18/22, 13:41
Reply
Yeah. But we should discuss this (and even with more experienced people from the core team) .. before just changing it around. -
Simon Schaufelberger voted on patch set 4 CR +1 04/21/22, 21:53
-
Oli Bartsch commented on patch set 4 04/22/22, 09:05
Gruntfile.js:70UnresolvedCould we please make this consistent with the other sysext paths? fluid_styled_content: '<%= paths.sysext %>fluid_styled_content/Resources/'Gruntfile.js:137UnresolvedWhy are they not stored in paths.sass? -
Nikita Hovratov updated the commit message in patch set 5 04/22/22, 16:43
-
Nikita Hovratov commented on patch set 5 04/22/22, 16:45
Hey guys, before nitpicking, let's discuss if this change even makes sense in this form. An alternative would be to add another static TypoScript template for this, so we avoid a breaking change. What do ya'll think? -
core-ci voted on patch set 5 V +1 04/22/22, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26311
-
Chris Müller wrote 04/24/22, 07:37
Removed cc Chris Müller. -
Benjamin Franzke rebased onto patch set 6 05/13/22, 07:02
-
core-ci voted on patch set 6 V -1 05/13/22, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27169
-
Benjamin Franzke uploaded patch set 7 08/12/22, 04:31
-
Benjamin Franzke commented on patch set 7 08/12/22, 04:31
Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:4ReplyDoneBreaking-96939-IntroduceFluidStyledContentCssVariables.rst:14ReplyDoneBreaking-96939-IntroduceFluidStyledContentCssVariables.rst:28ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:4ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:13ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:26ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:29ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:39ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:52ReplyDoneFeature-96939-IntroduceFluidStyledContentCssVariables.rst:55ReplyDone -
core-ci voted on patch set 7 V +1 08/12/22, 04:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30059
-
Nikita Hovratov abandoned the change 07/29/23, 21:16
was just a poc. Not sure if worth continuing.