Review main Abandoned Breaking

73527[POC][!!!][FEATURE] Introduce CSS variables for FSC styling options

Nikita Hovratov CR 0 V 0 Hard +526 −81 updated 07/29/23, 21:16

Commit message

This patch introduces css variables for fluid styled
content TypoScript styling options.

The advantage is that themes can make use of those
css variables. Before, there was no other way to
use style settings in own css stylesheets.

The FSC stylesheets are now generated in the main
build process, by extracting them in own scss files.
The resulting minified css files are included by the
AssetCollector in their corresponding template.

The styles still respect config.removeDefaultCss and
are not included if set to "1". Also, if the
optional TypoScript template for CSS is not included
the styles won't be added.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 25

Show 5 more files

Review log 2128

Show 23 earlier messages
  1. Nikita Hovratov uploaded patch set 1 02/15/22, 19:22

  2. Benjamin Franzke commented on patch set 1 02/15/22, 19:26

    nice idea <3
  3. core-ci voted on patch set 1 V -1 02/15/22, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23654

  1. Benni Mack commented on patch set 1 02/15/22, 20:31

    wow. nice!
  2. Nikita Hovratov uploaded patch set 2 02/17/22, 09:50

  3. core-ci voted on patch set 2 V -1 02/17/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23778

  4. Nikita Hovratov uploaded patch set 3 02/17/22, 10:03

  5. core-ci voted on patch set 3 V +1 02/17/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23780

  6. Stefan Bürk commented on patch set 3 02/18/22, 00:38

    Textmedia.html:11

    Guessing this is a leftover. Shipped debug output is kinda weired.

    RequestHandler.php:407

    Can we please split this now in multilines after this is now a more nested and complex condition, or would do you think ?
  7. Nikita Hovratov uploaded patch set 4 02/18/22, 08:37

  8. Nikita Hovratov commented on patch set 3 02/18/22, 08:37

    Textmedia.html:11 Reply

    whoops, that should not be there

    RequestHandler.php:407 Reply

    Done
  9. core-ci voted on patch set 4 V +1 02/18/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23863

  10. Chris Müller commented on patch set 4 02/18/22, 12:29

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:4

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:14

    "CSS custom properties"

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:28

    HTML

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:4

    I propose to use the offical name "CSS custom properties", perhaps with addition "variables" like in the MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:13

    "CSS custom properties"

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:26

    SCSS files

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:29

    SCSS

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:39

    seperate => separate

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:52

    "CSS custom properties"

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:55

    SCSS
  11. Stefan Bürk commented on patch set 4 02/18/22, 12:52

    Generally I love this idea behind this patch, thus thanks for your work on this already Nikita. However I have to throw one think into the discussion pot: Generally Typo3 is really really conservative in client/browser requirements for the frontend, from the core side. Better to say, totally open. And leaving this to the agencies, integrators, projects etc what they want to use to deliver frontend content and for which devices, browsers and so on. With this patch using this CSS Variable thing the core puts "requirements" out for the frontend and cut the decision freedom down. At least if this default css is used. Yes, I know there is a breaking ReST file stating this, but I think we should really think a moment about it - and this should eventually be more prominently published then - otherwise we would have a bunch of questions about this in the slack chanells eventually. Don't get me wrong - not to block this, just to raise awarness if this point a little bit more.
  12. Nikita Hovratov commented on patch set 4 02/18/22, 13:25

    Reply

    Thanks for the feedback! I love to have a discussion. Yes, TYPO3 should not mandate, what to use for the frontend. I'm totally open to change this to an optional feature, as the optional CSS is already. Adding a new static template: "Fluid Styled Content Optional (CSS variables)" or so might be a good idea, and it's not breaking anymore.
  13. Stefan Bürk commented on patch set 4 02/18/22, 13:41

    Reply

    Yeah. But we should discuss this (and even with more experienced people from the core team) .. before just changing it around.
  14. Simon Schaufelberger voted on patch set 4 CR +1 04/21/22, 21:53

  15. Oli Bartsch commented on patch set 4 04/22/22, 09:05

    Gruntfile.js:70 Unresolved

    Could we please make this consistent with the other sysext paths? fluid_styled_content: '<%= paths.sysext %>fluid_styled_content/Resources/'

    Gruntfile.js:137 Unresolved

    Why are they not stored in paths.sass?
  16. Nikita Hovratov updated the commit message in patch set 5 04/22/22, 16:43

  17. Nikita Hovratov commented on patch set 5 04/22/22, 16:45

    Hey guys, before nitpicking, let's discuss if this change even makes sense in this form. An alternative would be to add another static TypoScript template for this, so we avoid a breaking change. What do ya'll think?
  18. core-ci voted on patch set 5 V +1 04/22/22, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26311

  19. Chris Müller wrote 04/24/22, 07:37

    Removed cc Chris Müller.
  20. Benjamin Franzke rebased onto patch set 6 05/13/22, 07:02

  21. core-ci voted on patch set 6 V -1 05/13/22, 07:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27169

  22. Benjamin Franzke uploaded patch set 7 08/12/22, 04:31

  23. Benjamin Franzke commented on patch set 7 08/12/22, 04:31

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:4 Reply

    Done

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:14 Reply

    Done

    Breaking-96939-IntroduceFluidStyledContentCssVariables.rst:28 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:4 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:13 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:26 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:29 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:39 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:52 Reply

    Done

    Feature-96939-IntroduceFluidStyledContentCssVariables.rst:55 Reply

    Done
  24. core-ci voted on patch set 7 V +1 08/12/22, 04:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30059

  25. Nikita Hovratov abandoned the change 07/29/23, 21:16

    was just a poc. Not sure if worth continuing.