Review main Merged

73553[TASK] Align type hints in two classes implementing \ArrayAccess

Stefan Bürk CR +2 V +2 Easy +13 −21 updated 02/16/22, 08:59

Commit message

This patch aligns \ArrayAccess argument and return type hints in
two classes of 'ext:form' to be compatible with the implemented
native php interface '\ArrayAccess'. PHP8.1 added proper return
types to php internal classes, methods and interfaces, but using
'mixed' was not possible before because of PHP7.4 incompatibility.
To mitigate this the PHP8.1 attribute '#[\ReturnTypeWillChange]'
has been used in v11, which is now removed again.

These classes are already flagged as @internal and thus changed
now without further notice.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 68

  1. Stefan Bürk uploaded patch set 1 02/15/22, 21:44

  2. core-ci voted on patch set 1 V +1 02/15/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23666

  3. Georg Ringer commented on patch set 1 02/15/22, 21:58

    If marked as breaking, also add an rst pls
  4. Stefan Bürk updated the commit message in patch set 2 02/15/22, 22:01

  5. core-ci voted on patch set 2 V +1 02/15/22, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23670

  6. Benni Mack commented on patch set 2 V +1 CR +1 02/16/22, 06:57

    Reply

    both classes are internal
  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/16/22, 08:59

  8. Christian Kuhn merged patch set 3 02/16/22, 08:59