Review main Merged

73554[TASK] Require moduleData to be set in request

Oli Bartsch CR +2 V +2 Normal +29 −32 updated 02/16/22, 09:20

Commit message

Since #96895, the ModuleData object is created
for every request, targeting a backend module, and
attached to the PSR-7 Request object.

Previously the route targets (the controllers) made
use of the nullsafe operator when accessing the
module data. This however hides the dependency to
the object. In case the module data is missing, the
controller should fail "hard".

Therefore, those nullsafe operators are removed again.

Additionally, the $default value is removed from the
moduleData->get() calls, since the requested properties
are all registered in the module registration with a
corresponding default value.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4