Review main Merged

73597[BUGFIX] Fix PHP 8.1 warning in StoragePermissionsAspect

Benjamin Franzke CR +2 V +2 Easy +5 −33 updated 02/18/22, 16:02

Commit message

BackendUserAuthentication isn't an injectable service,
therefore the (unused) dependency injection is dropped
and $GLOBALS['BE_USER'] usage is moved to be scoped
by the isBackend() check.

Also fix the same DI-anti-pattern in CategoryPermissionsAspect.
No user facing error is currently known for this case,
as the ModifyTreeDataEvent is only executed in backend
context, so this is just to streamline both aspects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benjamin Franzke uploaded patch set 1 02/18/22, 07:12

  2. Benjamin Franzke uploaded patch set 2 02/18/22, 07:20

  3. Benjamin Franzke uploaded patch set 3 02/18/22, 07:22

  4. core-ci voted on patch set 1 V -1 02/18/22, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23850

  5. core-ci voted on patch set 3 V +1 02/18/22, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23852

  6. Benni Mack voted on patch set 3 V +1 CR +1 02/18/22, 15:59

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 02/18/22, 16:02

  8. Benni Mack voted on patch set 3 V +2 CR +2 02/18/22, 16:02

  9. Benni Mack merged patch set 4 02/18/22, 16:02