Review main Merged

73601[TASK] Avoid int-casting of TSFE->type

Benni Mack CR +2 V +2 Easy +4 −8 updated 02/18/22, 17:35

Commit message

Since Site Handling was introduced in TYPO3 v9,
TSFE->type is always set in the constructor and cast
to "int".

The "$TSFE->type" property is not itself marked as "int"
type as there might be more usages to "type" in future
v12 iterations.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. Benni Mack uploaded patch set 1 02/18/22, 15:22

  2. core-ci voted on patch set 1 V +1 02/18/22, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23879

  3. Benni Mack updated the commit message in patch set 2 02/18/22, 15:40

  4. Benni Mack updated the commit message in patch set 3 02/18/22, 15:42

  5. core-ci voted on patch set 2 V +1 02/18/22, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23881

  6. core-ci voted on patch set 3 V +1 02/18/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23882

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 02/18/22, 16:06

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 02/18/22, 16:17

  9. Stefan Bürk wrote 02/18/22, 16:28

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  10. Stefan Bürk wrote 02/18/22, 16:28

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  11. Oliver Klee voted on patch set 3 CR +1 02/18/22, 16:30

  12. Stefan Bürk voted on patch set 3 CR -1 02/18/22, 16:31

  13. Benni Mack commented on patch set 3 02/18/22, 16:46

    TypoScriptFrontendController.php:1273

    int cast is missing here.
  14. Oli Bartsch uploaded patch set 4 02/18/22, 17:01

  15. Oli Bartsch commented on patch set 4 02/18/22, 17:02

    TypoScriptFrontendController.php:1273 Reply

    Done
  16. Oli Bartsch voted on patch set 4 V +1 CR +1 02/18/22, 17:07

  17. core-ci voted on patch set 4 V +1 02/18/22, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23886

  18. Stefan Bürk voted on patch set 4 V +1 CR +1 02/18/22, 17:15

  19. Oli Bartsch voted on patch set 4 V +2 CR +2 02/18/22, 17:35

  20. Oli Bartsch merged patch set 5 02/18/22, 17:35