Review main Merged

73611[TASK] Use Typo3Fluid TemplateAwareViewInterface

Christian Kuhn CR +2 V +2 Easy +4 −12 updated 07/31/22, 08:26

Commit message

Fluid 2.7.2 brought optional TemplateAwareViewInterface.
This is used in two places for proper signatures and makes
phpstan a bit more happy.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 02/20/22, 09:21

  2. core-ci voted on patch set 1 V -1 02/20/22, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23927

  3. Christian Kuhn uploaded patch set 2 07/30/22, 12:25

  4. Christian Kuhn updated the commit message in patch set 3 07/30/22, 12:26

  5. core-ci voted on patch set 3 V +1 07/30/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29713

  6. Oliver Klee voted on patch set 3 V +1 CR +1 07/30/22, 17:31

  7. Stefan Bürk voted on patch set 3 V +2 CR +2 07/31/22, 08:26

  8. Stefan Bürk merged patch set 4 07/31/22, 08:26