Review main Merged Breaking

73622[!!!][FEATURE] Separate internal_type=folder into an own type

Nikita Hovratov CR +2 V +2 Expert +961 −405 updated 11/22/23, 21:44

Commit message

The TCA type group became more and more a pure
database relation type throughout the years. The
only annoyance that was still there is internal_type
with "folder" set. Although they are very similar
in the user interface, internally they are handled
completely separate. They share only a fraction of
common TCA properties, too.

This leads to checks for internal_type !== 'folder'
everywhere across the codebase. To avoid this,
folder must become an own type.

With folder as an own type, the code becomes much
more readable and there is a lot less if-branching.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 40

Show 20 more files