73651[BUGFIX] Workspace preview links with page starttime
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 1318
-
Christian Kuhn uploaded patch set 1 02/23/22, 08:53
-
core-ci voted on patch set 1 V +1 02/23/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24083
-
Christian Kuhn uploaded patch set 2 08/13/22, 07:10
-
core-ci voted on patch set 2 V +1 08/13/22, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30135
-
Benni Mack commented on patch set 2 CR -1 08/13/22, 12:20
will need to have a closer look -
Benni Mack commented on patch set 2 08/17/22, 14:43
PageRepository.php:1392this one is legit. +1 -
Benni Mack commented on patch set 2 08/17/22, 14:53
PageRepository.php:259I think we should check where ->getPage() is used in your use-case and use "checkIfPageIsHidden()" (which was introduced in v12) instead. -
Benni Mack updated the commit message in patch set 3
CR -1V +105/03/23, 09:22 -
core-ci voted on patch set 3 V -1 05/03/23, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41401
-
Benni Mack uploaded patch set 4
V -107/03/23, 19:51 -
Benni Mack commented on patch set 4 07/03/23, 19:51
PageRepository.php:259ReplyDonePageRepository.php:1392ReplyDone -
core-ci voted on patch set 4 V -1 07/03/23, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43288
-
Benni Mack updated the commit message in patch set 5
V -107/04/23, 10:55 -
core-ci voted on patch set 5 V -1 07/04/23, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43367
-
Christian Weiske commented on patch set 5 CR -1 V -1 07/31/24, 11:43
Unresolved
I backported this patch to TYPO3v11 (only the comments in the 3rd hunk are different) and noticed several problems: 1. The page loads now instead of a 404 2. The content elements on the page are not shown at all 3. The original page returns a 404 (seen when using the slider to switch to the original version) -
Benni Mack updated the commit message in patch set 6
CR -1V -110/18/24, 13:39 -
Benni Mack marked it work in progress 03/28/25, 12:13
-
Benni Mack abandoned the change 10/13/25, 13:15
We should use this approach https://review.typo3.org/c/Packages/TYPO3.CMS/+/90782