Review main Abandoned

73651[BUGFIX] Workspace preview links with page starttime

Christian Kuhn CR 0 V 0 Easy +20 −6 updated 10/13/25, 13:15

Commit message

Have a page in live with starttime in the future.
Go to workspace module, select that page, generate
preview links or preview side-by-side.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 1318

  1. Christian Kuhn uploaded patch set 1 02/23/22, 08:53

  2. core-ci voted on patch set 1 V +1 02/23/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24083

  3. Christian Kuhn uploaded patch set 2 08/13/22, 07:10

  4. core-ci voted on patch set 2 V +1 08/13/22, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30135

  5. Benni Mack commented on patch set 2 CR -1 08/13/22, 12:20

    will need to have a closer look
  6. Benni Mack commented on patch set 2 08/17/22, 14:43

    PageRepository.php:1392

    this one is legit. +1
  7. Benni Mack commented on patch set 2 08/17/22, 14:53

    PageRepository.php:259

    I think we should check where ->getPage() is used in your use-case and use "checkIfPageIsHidden()" (which was introduced in v12) instead.
  8. Benni Mack updated the commit message in patch set 3 CR -1 V +1 05/03/23, 09:22

  9. core-ci voted on patch set 3 V -1 05/03/23, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41401

  10. Benni Mack uploaded patch set 4 V -1 07/03/23, 19:51

  11. Benni Mack commented on patch set 4 07/03/23, 19:51

    PageRepository.php:259 Reply

    Done

    PageRepository.php:1392 Reply

    Done
  12. core-ci voted on patch set 4 V -1 07/03/23, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43288

  13. Benni Mack updated the commit message in patch set 5 V -1 07/04/23, 10:55

  14. core-ci voted on patch set 5 V -1 07/04/23, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43367

  15. Christian Weiske commented on patch set 5 CR -1 V -1 07/31/24, 11:43

    Unresolved

    I backported this patch to TYPO3v11 (only the comments in the 3rd hunk are different) and noticed several problems: 1. The page loads now instead of a 404 2. The content elements on the page are not shown at all 3. The original page returns a 404 (seen when using the slider to switch to the original version)
  16. Benni Mack updated the commit message in patch set 6 CR -1 V -1 10/18/24, 13:39

  17. Benni Mack marked it work in progress 03/28/25, 12:13

  18. Benni Mack abandoned the change 10/13/25, 13:15